Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix @/climatemappedafrica HURUmap data handling #989

Merged
merged 9 commits into from
Nov 5, 2024
Merged

Fix @/climatemappedafrica HURUmap data handling #989

merged 9 commits into from
Nov 5, 2024

Conversation

kilemensi
Copy link
Member

Description

  • Load HURUmap profile only when HURUmap is enabled
  • Include HURUmap related blocks when HURUmap is enabled
  • Ensure data loading functions use similar arguments

PENDING
@koechkevin what should happen to the site Hero when HURUmap is disabled? Handle it in a separate PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore

Screenshots

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@kilemensi kilemensi added bug Something isn't working chore A task that needs to be done (neither enhancement or bug) labels Nov 5, 2024
@kilemensi kilemensi self-assigned this Nov 5, 2024
@kilemensi kilemensi requested a review from a team November 5, 2024 10:27
@koechkevin
Copy link
Contributor

@koechkevin what should happen to the site Hero when HURUmap is disabled? Handle it in a separate PR.

@kilemensi this PR will fix that.

@kilemensi
Copy link
Member Author

@kilemensi this PR will fix that.

Cool @koechkevin. Fix it how?

@koechkevin
Copy link
Contributor

@kilemensi this PR will fix that.

Cool @koechkevin. Fix it how?

@kilemensi Hero component only needs explore page slug to naavigate to when you click a location on the HeroMap. So we do not trigger router.push if explorePageSlug is null.

@kilemensi
Copy link
Member Author

@kilemensi Hero component only needs explore page slug to naavigate to when you click a location on the HeroMap. So we do not trigger router.push if explorePageSlug is null.

Cool, cool @koechkevin ... then don't do the hover styling as well i.e. don't give the user the indication that something is clickable when it isn't.

kelvinkipruto
kelvinkipruto approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@kelvinkipruto kelvinkipruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kilemensi
Copy link
Member Author

If all is good @kelvinkipruto / @koechkevin, please merge and deploy (I'll be stuck in meetings for the next 3 hours).

@kelvinkipruto kelvinkipruto added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 008da14 Nov 5, 2024
4 checks passed
@kelvinkipruto kelvinkipruto deleted the fix/climatemappedafrica_hurumap branch November 5, 2024 11:21
@koechkevin
Copy link
Contributor

LGTM, I expect this to fail Push to DOKKU step only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelvinkipruto kelvinkipruto kelvinkipruto approved these changes

Assignees

@kilemensi kilemensi

Labels
bug Something isn't working chore A task that needs to be done (neither enhancement or bug)
Projects
COMMONS
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kilemensi @koechkevin @kelvinkipruto